added container scanning to attribute-service repo #132
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
=========================================
Coverage 81.47% 81.47%
Complexity 230 230
=========================================
Files 28 28
Lines 772 772
Branches 60 60
=========================================
Hits 629 629
Misses 93 93
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. |
| id: tag | ||
| run: echo ::set-output name=tag::$(./gradlew -q printDockerImageDefaultTag | head -1) | ||
|
|
||
| - name: Scan docker image |
There was a problem hiding this comment.
Can we move this into the test job (or give it its own?)
There was a problem hiding this comment.
It is scanning the container image created just before this step. if we move it to another job then we will have to build docker image again.
There was a problem hiding this comment.
I guess the tradeoff here is we've already built the image vs the test job is the more appropriate place to run this... test. Given that we want to login in order to build the job though, we'd need a new job anyway so I suppose it's moot. Carry on.
There was a problem hiding this comment.
The repetition is less concerning to me - we do 90% of that in the test job to run integration tests, for example. The problem is the secret management - whatever job builds the image needs to be in this workflow (specifically, triggered by pull_request_target rather than pull_request which is what test uses), so we'd need a brand new job if we wanted to separate it which isn't worth it.
Description
Please include a summary of the change, motivation and context.
added container scanning to attribute-service repo
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.